Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RestClient in ChromaApi #717

Closed

Conversation

eddumelendez
Copy link
Contributor

Use RestClient internally but uses the configuration from RestTemplate. RestTemplate uses SimpleClientHttpRequestFactory meanwhile RestClient uses JdkClientHttpRequestFactory and produces unsupported upgrade request when making a request to chroma.

Use RestClient internally but uses the configuration from RestTemplate.
RestTemplate uses SimpleClientHttpRequestFactory meanwhile RestClient
uses JdkClientHttpRequestFactory and produces `unsupported upgrade request`
when making a request to chroma.
@tzolov tzolov added enhancement New feature or request vectors store labels May 21, 2024
@markpollack markpollack added this to the 1.0.0-M2 milestone May 24, 2024
@tzolov tzolov self-assigned this Jun 16, 2024
@tzolov
Copy link
Collaborator

tzolov commented Jun 16, 2024

Thanks @eddumelendez !
I made few additional:

  • get rid of any RestTemplate usage.
  • make the RestClient default to SimpleClientHttpRequestFactory as Chroma has issues with HTTP2.
  • update the documentation.
  • update the ghcr.io/chroma-core/chroma version to 0.5.0. Fix the withBasicAuthCredentials.

rebased, squashed and merged at 704dec2

@tzolov tzolov closed this Jun 16, 2024
@eddumelendez eddumelendez deleted the chroma-restclient branch June 16, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vectors store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants