Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Amazon Bedrock Converse API to re-implementing Bedrock AI Models. #813

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

maxjiang153
Copy link
Contributor

@maxjiang153 maxjiang153 commented Jun 2, 2024

see: #809

Provide a new BedrockConverseApi for AI model chat usage.
Re-implementing current chat models from AbstractBedrockApi to the Bedrock Converse API to reduce complexity.
Re-implementing Bedrock chat model usage information: #605.
Support build-in exponential backoff: #759.

things todo:

@maxjiang153 maxjiang153 force-pushed the aws-bedrock-converse branch 7 times, most recently from a96e2b9 to 68b544a Compare June 4, 2024 04:48
@maxjiang153 maxjiang153 marked this pull request as draft June 4, 2024 05:18
@maxjiang153 maxjiang153 force-pushed the aws-bedrock-converse branch 2 times, most recently from 0efbb59 to eeccd04 Compare June 4, 2024 14:19
@maxjiang153
Copy link
Contributor Author

@tzolov Hi Christian, I'm basically finished re-implementing Bedrock AI models with the Amazon Bedrock Converse API. But there are some thing's I'd like to discuss.

  1. Because of the Amazon Bedrock Converse API, bedrock chat models don't need such things as Anthropic3ChatBedrockApi anymore. Should I remove the old Apis?
  2. Bedrock Mistral and Cohere Command R model which are not supported yet. Should I includes these models in this PR?

@maxjiang153 maxjiang153 marked this pull request as ready for review June 9, 2024 02:29
@maxjiang153 maxjiang153 changed the title [WIP] Use Amazon Bedrock Converse API to re-implementing Bedrock AI Models. Use Amazon Bedrock Converse API to re-implementing Bedrock AI Models. Jun 9, 2024
@Hakenadu
Copy link

Is it realistic to expect this PR to be merged before 1.0.0?
That would be great to see.

@DEG-7
Copy link

DEG-7 commented Jun 14, 2024

Is it realistic to expect this PR to be merged before 1.0.0? That would be great to see.

I hope that, I'm looking forward to have this PR merged as soon as possible too...

@maxjiang153
Copy link
Contributor Author

I hope so, This is a huge PR, Maybe we can review it by ourselves first to reduce the workload for the team members

@maxjiang153
Copy link
Contributor Author

Hello @tzolov Any advice on this PR?

@DEG-7
Copy link

DEG-7 commented Jun 27, 2024

Hi @maxjiang153, it's a pity that there is no news about this PR, maybe it's too big, I don't know....
@tzolov @markpollack any thoughts on how to move forward with this?

Thanks all for the huge effort !!

@tzolov
Copy link
Collaborator

tzolov commented Jun 27, 2024

Hi @maxjiang153 ,

Thank you very much for the great (and big ;) contribution.

Sorry for not reaching out earlier. We've been quite busy and lacking the manpower to review and address all PRs.

The #813 has a hight priority for me and I hope to be able to jump on it soon.

@maxjiang153
Copy link
Contributor Author

@tzolov As Amazon Bedrock is rapidly involved and the AI 21 Jamba model is just generally available, I wonder: should I keep moving on this PR to support this new model or wait for this PR to be merged and then create a new PR to support the new model?

Check this out: https://aws.amazon.com/about-aws/whats-new/2024/06/ai21-labs-jamba-instruct-model-amazon-bedrock/

@DEG-7
Copy link

DEG-7 commented Jul 18, 2024

@maxjiang153 it would be great if you can update the PR with the latest changes in the project, so it can be easily reviewed by @tzolov.
Thanks to both very much !

@lameroot
Copy link

waiting ....

@maxjiang153
Copy link
Contributor Author

@DEG-7 I see that maintaining this PR with upstream is heavy work, I'm not sure when team members will work on this PR, but I'll keep an eye out for when it will be reviewed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants