Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Javadocs for MessageProperties.expiration #1539

Closed
german-komarov opened this issue Nov 25, 2022 · 1 comment
Closed

Missing Javadocs for MessageProperties.expiration #1539

german-komarov opened this issue Nov 25, 2022 · 1 comment

Comments

@german-komarov
Copy link

Will this issue be solved, because neither in the code, nor in docs https://docs.spring.io/spring-amqp/api/org/springframework/amqp/core/MessageProperties.html#setExpiration(java.lang.String) , it is not clear in which format this "String expiration" parameter can be set. Can you clarify or fix it, please.

P.S Anyway thank you for amazing amqp library, it is really powerful and useful.

@garyrussell
Copy link
Contributor

This is just a reflection of the underlying AMQP 0.9.1 specification which, oddly, defines the property as a String.

https://www.rabbitmq.com/protocol.html

https://www.rabbitmq.com/resources/specs/amqp-xml-doc0-9-1.pdf

It, too, has no indication of the format.

This document indicates it is a String representing the time to live in milliseconds.

https://www.rabbitmq.com/ttl.html

We will update the javadocs to reflect that.

@garyrussell garyrussell changed the title Unresolved issue Missing Javadocs for MessageProperties.expiration Nov 25, 2022
garyrussell added a commit that referenced this issue Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants