Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headers exchange declaration ignores "name" property #824

Closed
Scip88 opened this Issue Oct 10, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@Scip88
Copy link

Scip88 commented Oct 10, 2018

When Logger declares an exchange of type "Headers" , it is declared with name "headers" instead of provided name

@Scip88 Scip88 changed the title headers exchange declaration ignored "name" property headers exchange declaration ignores "name" property Oct 10, 2018

@garyrussell

This comment has been minimized.

Copy link
Member

garyrussell commented Oct 10, 2018

@Scip88

This comment has been minimized.

Copy link
Author

Scip88 commented Oct 10, 2018

Sorry for poor informations

Log4j2 Appender.

class: org.springframework.amqp.rabbit.log4j2.AmqpAppender
line: 718-720

else if ("headers".equals(this.exchangeType)) {
x = new HeadersExchange(this.exchangeType, this.durable, this.autoDelete);
}

Correct Code is
else if ("headers".equals(this.exchangeType)) {
x = new HeadersExchange(this.exchangeName, this.durable, this.autoDelete);
}

@garyrussell

This comment has been minimized.

Copy link
Member

garyrussell commented Oct 10, 2018

Ah - ok; thanks - copy/paste syndrome 😦 .

@Scip88

This comment has been minimized.

Copy link
Author

Scip88 commented Oct 10, 2018

you're welcome.
next time i try to do a pull request

@garyrussell garyrussell self-assigned this Oct 10, 2018

garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Oct 10, 2018

artembilan added a commit that referenced this issue Oct 10, 2018

artembilan added a commit that referenced this issue Oct 10, 2018

GH-824: Fix Log4j2Appender with headers exchange
Fixes #824

**cherry-pick to 2.0.x*

(cherry picked from commit 74354d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.