GH-1296: Fix DMLC Recovery: Missing Queue at Start #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#1296 - Add `MissingQueueEvent` - Fix detection of a deleted queue in recovery - previously incorrectly used the absense of the queue in `consumersByQueue`, which can be empty if missing during start - Add an index to `SimpleConsumer` - When adjusting consumer counts, look for gaps in the index sequence because reducing the consumer count can remove any idle consumer. - Change consumers to restart to a `Set` to avoid OOM when no broker (see spring-projects#642) - Unconditionally add consumers to `consumersToRestart` **cherry-pick to 2.2.x, 2.1.x**
artembilan
approved these changes
Jan 12, 2021
There was a problem hiding this comment.
So smart!
I also thought about moving to Set for consumers to avoid OOM, but then it was a problem for me to figure out how to make them unique.
The index is a good solution although it is hard to digest it at a glance why would one be so strict trying to fill the gaps 😄
I mean we just could use unique ids for consumers to reuse them on restart.
However I find your solution less stressful than those UUIDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1296
MissingQueueEventabsense of the queue in
consumersByQueue, which can be empty if missing duringstart
SimpleConsumerthe consumer count can remove any idle consumer.
Setto avoid OOM when no broker(see Fix possible memory leak during DirectMessageListenerContainer startup #642)
consumersToRestartcherry-pick to 2.2.x, 2.1.x