-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-1444: Listener Observability Initial Commit #1500
Merged
Merged
Changes from 14 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
6f35711
GH-1444: Listener Observability Initial Commit
garyrussell 3c767f1
Rename Sender/Receiver contexts and other PR review comments.
garyrussell 0886783
Rename contexts to Rabbit...; supply default KeyValues via the conven…
garyrussell 355f5db
Javadoc polishing.
garyrussell b39a5f9
Don't add default KV to high-card KVs.
garyrussell 393ed51
Fix previous commit.
garyrussell c282d46
Fix contextual name (receiver side).
garyrussell c5b2975
Fix checkstyle.
garyrussell 9de2da2
Polish previous commit.
garyrussell 55f0437
Fix contextual name (sender side)
garyrussell 3079268
Remove contextual names from observations.
garyrussell 0cf3e55
Fix checkstyle.
garyrussell d929b0f
Remove customization of KeyValues from conventions.
garyrussell b1bd023
Add `getDefaultConvention()` to observations.
garyrussell be4be28
Fix since 3.0.
garyrussell d422412
Support wider convention customization.
garyrussell d762752
Convention type safety.
garyrussell f1ac117
Fix Test - not sure why PR build succeeded.
garyrussell 03ccb33
Add Meters to ObservationTests.
garyrussell 2557794
Fix checkstyle.
garyrussell 970ba6c
Make INSTANCE final.
garyrussell a528d09
Add integration test.
garyrussell 1927f3b
Test all available integrations.
garyrussell cb6ba4c
Remove redundant test code.
garyrussell d0b758e
Move getContextualName to conventions.
garyrussell 0043280
Add docs.
garyrussell 599d5b7
Fix doc link.
garyrussell 38589a0
Remove unnecessary method overrides; make tag names more meaningful.
garyrussell d5464ab
Move getName() from contexts to conventions.
garyrussell 4ec81a1
Fix Race in Test
garyrussell 2651f1c
Fix Race in Test.
garyrussell File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcingrzejszczak ,
is this what you have expected?
I thought the idea was just about a general
ObservationConvention<RabbitMessageSenderContext>
and that's it...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, now it looks (almost) perfect!
RabbitTemplateObservationConvention
could be an interface that just extends theObservationConvention<RMSC>
. You would have theDefaultRTOC
that would implement theRTOC
.You can check
for more info