AMQP-500: Configurable SSL Algo, No Properties #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: https://jira.spring.io/browse/AMQP-500 Enable algorithm selection when not using certificates.
| fb.setUseSSL(true); | ||
| fb.afterPropertiesSet(); | ||
| fb.getObject(); | ||
| verify(rabbitCf).useSslProtocol(); |
There was a problem hiding this comment.
Nothing to complain about, but before I merge it, please, let me know if we should change our default algorithm from TLSv1.1 to TLSv1 as it is in the com.rabbitmq.client.ConnectionFactory.
Or have I missed anything and it was really intentional to have it like this?
There was a problem hiding this comment.
IIRC, I made it 1.1 because of the beast attack.
There was a problem hiding this comment.
OK. I understand that. And it is good. So, see my comment on code changes.
|
Thank you, guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/AMQP-500
Enable algorithm selection when not using certificates.
cherry-pick to 1.4.x