Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide JDBC implementation of OAuth2AuthorizationConsentService #314

Merged
merged 1 commit into from Jun 18, 2021
Merged

Provide JDBC implementation of OAuth2AuthorizationConsentService #314

merged 1 commit into from Jun 18, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 17, 2021

Add new JDBC implementation of the OAuth2AuthorizationConsentService
Add equals and hashCode methods in OAuth2AuthorizationConsent

Closes gh-313

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 17, 2021
@ovidiupopa07
Provide JDBC implementation of OAuth2AuthorizationConsentService
0e3f000 
Add new JDBC implementation of the OAuth2AuthorizationConsentService
Add equals and hashCode methods in OAuth2AuthorizationConsent

Closes spring-projectsgh-313
@ghost
Copy link
Author

ghost commented Jun 17, 2021

hi @jgrandja / @sjohnr . The implementation is ready for review.

@jgrandja jgrandja requested a review from sjohnr June 17, 2021 13:43
@jgrandja jgrandja added this to the 0.1.2 milestone Jun 17, 2021
@jgrandja jgrandja added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 17, 2021
sjohnr
sjohnr reviewed Jun 17, 2021
View reviewed changes
Copy link
Member

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @ovidiupopa91! Please see my feedback inline.

...ingframework/security/oauth2/server/authorization/JdbcOAuth2AuthorizationConsentService.java Show resolved Hide resolved
...ingframework/security/oauth2/server/authorization/JdbcOAuth2AuthorizationConsentService.java Show resolved Hide resolved
@ghost ghost requested a review from sjohnr June 18, 2021 10:16
@sjohnr sjohnr merged commit 5dbe973 into spring-projects:main Jun 18, 2021
sjohnr added a commit that referenced this pull request Jun 18, 2021
@sjohnr
Polish gh-314
5e79f21 
Polish gh-304
@sjohnr sjohnr mentioned this pull request Jun 18, 2021
Closed
@sjohnr sjohnr added the status: duplicate A duplicate of another issue label Jun 28, 2021
sjohnr added a commit that referenced this pull request Jun 29, 2021
@sjohnr
Polish gh-314
6f6829b
jgrandja added a commit that referenced this pull request Jul 9, 2021
@jgrandja
Polish JdbcOAuth2AuthorizationConsentService
ad108f5 
Issue gh-314
doba16 pushed a commit to doba16/spring-authorization-server that referenced this pull request Apr 21, 2023
@sjohnr
Polish spring-projectsgh-314
803177b 
Polish spring-projectsgh-304
doba16 pushed a commit to doba16/spring-authorization-server that referenced this pull request Apr 21, 2023
@sjohnr
Polish spring-projectsgh-314
1b7b883
doba16 pushed a commit to doba16/spring-authorization-server that referenced this pull request Apr 21, 2023
@jgrandja
Polish JdbcOAuth2AuthorizationConsentService
304b0e1 
Issue spring-projectsgh-314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sjohnr sjohnr

Labels
status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
0.1.2
Development

Successfully merging this pull request may close these issues.

Provide JDBC implementation of OAuth2AuthorizationConsentService
4 participants
@sjohnr @jgrandja @spring-projects-issues @ovidiupopa07