Enhance validation for configured Issuer #649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jgrandja
requested changes
Mar 29, 2022
There was a problem hiding this comment.
Thanks for the PR @NotFound403. Please see review comments.
...ork/security/config/annotation/web/configuration/OAuth2AuthorizationServerConfiguration.java
Outdated
Show resolved
Hide resolved
...otation/web/configurers/oauth2/server/authorization/OAuth2AuthorizationServerConfigurer.java
Show resolved
Hide resolved
...n/java/org/springframework/security/oauth2/server/authorization/config/ProviderSettings.java
Outdated
Show resolved
Hide resolved
jgrandja
added
type: enhancement
jgrandja
changed the title
NotFound403
commented
Mar 30, 2022
jgrandja
requested changes
Apr 28, 2022
There was a problem hiding this comment.
Thanks for the updates @NotFound403. Please see review comments.
Also, please squash commits and rebase on main. There should only be 1 commit as part of this change.
...otation/web/configurers/oauth2/server/authorization/OAuth2AuthorizationServerConfigurer.java
Outdated
Show resolved
Hide resolved
...otation/web/configurers/oauth2/server/authorization/OAuth2AuthorizationServerConfigurer.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/security/oauth2/server/authorization/config/ProviderSettingsTests.java
Outdated
Show resolved
Hide resolved
NotFound403
force-pushed
the
provider/iss
branch
from
161f789
to
29f4362
Compare
|
Thanks for the updates @NotFound403. This is now merged in FYI, I added a bit of polish to the tests. |
Thank you，Joe |
doba16
pushed a commit
to doba16/spring-authorization-server
that referenced
this pull request
Apr 21, 2023
doba16
pushed a commit
to doba16/spring-authorization-server
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rfc8414#section-2
The "https" schema in development may be unsuited, but others should be vailidated.
I'm not sure if the above has been considered, further discussion is required