BATCH-2041: Add support for reading excel files #2

mdeinum · 2014-03-24T19:32:32Z

This commit adds support for reading Excel files. Both JExcel and Apache POI are supported. Support for reading Excel files has been designed similar to the support for reading flat files.

I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.

mminella · 2014-03-31T18:24:30Z

spring-batch-excel/pom.xml

+
+    <groupId>org.springframewor.batch</groupId>
+    <artifactId>spring-batch-excel</artifactId>
+    <version>1.3.0.BUILD-SNAPSHOT</version>


This should be 0.5.0.BUILD-SNAPSHOT or something along those lines. Since we don't have a release yet, it shouldn't be above 1.0

Done. Initially left the versions we used internally, now it is a 0.5.0.BUILD-SNAPSHOT.

mminella · 2014-04-01T17:02:21Z

Overall, this looks like a solid start. Beyond the line specific comments above, some more general comments:

Version numbers - Since this is the initial release of all of this code, I'd expect them all to be in sync.
Copyright date - Same as version numbers. I'd expect all the dates to be the same (and be either just 2014 or 2013-2014).
@Override for implementing interfaces - Can we get @Override applied to methods that implement interface methods?

…sion.

JUnit 4.12 Mockito 1.10.19 Fixed scope of Spring-test dependency

Removed the doCloseWorkbook method in favor of the normal doClose method. The PoiItemReader now closes the InputStream and Workbook (for Apache POI >= 3.11)

Remove <p> and </p> where they didn't match.

Fixed javadoc errors and warnings

Added package-info files.

inline numberOfRows, numberOfColumns and the name for performance.

Fixed typo

Cache FormulaEvaluator instead of creating a new one.

Use the BeanWrapper to bind values to beans. Based on the BeanWrapperFieldSetMapper.

Added Java Config Added BeanWrapperRowMapper

Numeric type can contain a Date instead of a number, check added for Date and return the time in millis if a Date is found.

dusiema · 2015-03-04T11:02:02Z

Will this be merged any time soon? What is the current status of this?

mminella · 2015-03-04T15:38:57Z

Unless you have any objections, I'm going to merge this with one small update which is to update the @Depricated notes to point to the POI implementation (so users know what to use instead).

dusiema · 2015-03-04T15:48:24Z

No, I don't have any. I am using this already as a clone from https://github.com/mdeinum/spring-batch-extensions. While using it I found one or two things that could be improved (like being able to specify just one sheet in an excel file). But I think this could also be done, when it is integrated into this repo.

mdeinum · 2015-03-05T11:27:52Z

@mminella Would this be worth a blog post explaining things a little?

@dusiema Maybe you could create an issue here at github and provide a pull request if you already have the code (after it has been merged ofcourse).

dusiema · 2015-03-05T17:01:09Z

@mdeinum: I don't have the code yet (I just deleted all the other sheets from the excel file). I will create an enhancement issue and mabye I can also provide a pull request later on. However before creating the issue in this repo I guess the code should be here first.

dusiema · 2015-03-11T12:32:59Z

@mminella: Any update on the integration? I have two more enhancement suggestions and I could provide pull-requests for them. I just thought I could provide them right here instead of the repo from @mdeinum.

mdeinum · 2015-03-11T19:21:43Z

@dusiema If you have the enhancements you can create 1 or 2 pull requests to my repo. I'll merge them and then they should show up here also.

dusiema · 2015-03-11T20:28:30Z

@mdeinum I already thought about that. Need to get back to my computer at work. I'll try to do it tomorrow.

mminella · 2015-03-11T20:30:41Z

Hey guys, I'm at a conference through tomorrow. I plan on merging this Friday.

dusiema · 2015-03-11T20:37:05Z

@mminella Cool.
I'll try to do the pull request anyways so @mdeinum can have a look first.

mminella · 2015-03-13T15:35:41Z

Merged. Thanks for all the hard work!

mdeinum · 2015-03-13T18:52:53Z

Great... Thanks for merging it. I'll try to write a blog post in the next couple of days.

mdeinum added 2 commits March 24, 2014 20:27

Update to POI 3.10-FINAL.

81497c8

Added readme.

b2b3c0e

mminella reviewed Mar 31, 2014
View reviewed changes

mdeinum added 9 commits April 1, 2014 20:21

Removed <scope>compile</scope> from JExcel dependency

eca61eb

Changed pom version and @SInCE tags with classes to match the pom ver…

e35ff93

…sion.

Updated Copyright notices.

ee13cca

Added support for evaluating formulas.

04a02a7

Added @OverRide annotations.

3b0c6e9

Fixed typo in test message.

a518a4f

Merge remote-tracking branch 'upstream/master'

3a39c72

Merge remote-tracking branch 'upstream/master'

adf7ce3

Updated javadoc.

e723048

mdeinum added 11 commits January 19, 2015 20:11

Update test libraries and fix scope

dd9ae14

JUnit 4.12 Mockito 1.10.19 Fixed scope of Spring-test dependency

Cleanup of close methods.

36ddf79

Removed the doCloseWorkbook method in favor of the normal doClose method. The PoiItemReader now closes the InputStream and Workbook (for Apache POI >= 3.11)

Javadoc

20cce18

Remove <p> and </p> where they didn't match.

Javadoc

27fafa2

Fixed javadoc errors and warnings

Javadoc

d300e76

Added package-info files.

polish

d971e8a

inline numberOfRows, numberOfColumns and the name for performance.

polish javadoc

144ab34

Fixed typo

polish

b01b772

Cache FormulaEvaluator instead of creating a new one.

Replace BeanPropertyRowMapper with BeanWrapperRowMapper.

a8b7a1f

Use the BeanWrapper to bind values to beans. Based on the BeanWrapperFieldSetMapper.

polish

ada7ece

Added Java Config Added BeanWrapperRowMapper

polish

574fe24

Numeric type can contain a Date instead of a number, check added for Date and return the time in millis if a Date is found.

mminella assigned mminella and lucaslward and unassigned mminella Mar 13, 2015

mminella closed this Mar 13, 2015

mminella assigned mminella and unassigned lucaslward Mar 13, 2015

spring-projects-issues mentioned this pull request Dec 16, 2019

Add support for reading excel files [BATCH-2041] spring-projects/spring-batch#1553

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BATCH-2041: Add support for reading excel files #2

BATCH-2041: Add support for reading excel files #2

mdeinum commented Mar 24, 2014

mminella Mar 31, 2014

mdeinum Apr 1, 2014

mminella commented Apr 1, 2014

dusiema commented Mar 4, 2015

mminella commented Mar 4, 2015

dusiema commented Mar 4, 2015

mdeinum commented Mar 5, 2015

dusiema commented Mar 5, 2015

dusiema commented Mar 11, 2015

mdeinum commented Mar 11, 2015

dusiema commented Mar 11, 2015

mminella commented Mar 11, 2015

dusiema commented Mar 11, 2015

mminella commented Mar 13, 2015

mdeinum commented Mar 13, 2015

BATCH-2041: Add support for reading excel files #2

BATCH-2041: Add support for reading excel files #2

Conversation

mdeinum commented Mar 24, 2014

mminella Mar 31, 2014

Choose a reason for hiding this comment

mdeinum Apr 1, 2014

Choose a reason for hiding this comment

mminella commented Apr 1, 2014

dusiema commented Mar 4, 2015

mminella commented Mar 4, 2015

dusiema commented Mar 4, 2015

mdeinum commented Mar 5, 2015

dusiema commented Mar 5, 2015

dusiema commented Mar 11, 2015

mdeinum commented Mar 11, 2015

dusiema commented Mar 11, 2015

mminella commented Mar 11, 2015

dusiema commented Mar 11, 2015

mminella commented Mar 13, 2015

mdeinum commented Mar 13, 2015