Check the return value of File.delete()

Check the return value of File.delete() and throw an exception if deleting a file fails.
spring-projects · Dec 5, 2022 · 8ee023b · 8ee023b
1 parent 656e3f8
commit 8ee023b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...tructure/src/main/java/org/springframework/batch/item/support/AbstractFileItemWriter.java b/...tructure/src/main/java/org/springframework/batch/item/support/AbstractFileItemWriter.java
@@ -270,7 +270,9 @@ public void close() {
 				state.close();
 				if (state.linesWritten == 0 && shouldDeleteIfEmpty) {
 					try {
-						resource.getFile().delete();
+						if (!resource.getFile().delete()) {
+							throw new ItemStreamException("Failed to delete empty file on close");
+						}
 					}
 					catch (IOException e) {
 						throw new ItemStreamException("Failed to delete empty file on close", e);

diff --git a/...-infrastructure/src/main/java/org/springframework/batch/item/xml/StaxEventItemWriter.java b/...-infrastructure/src/main/java/org/springframework/batch/item/xml/StaxEventItemWriter.java
@@ -735,7 +735,9 @@ public void close() {
 			}
 			if (currentRecordCount == 0 && shouldDeleteIfEmpty) {
 				try {
-					resource.getFile().delete();
+					if (!resource.getFile().delete()) {
+						throw new ItemStreamException("Failed to delete empty file on close");
+					}
 				}
 				catch (IOException e) {
 					throw new ItemStreamException("Failed to delete empty file on close", e);