Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeanWrapperFieldSetMapper does not support Spring's ConversionService [BATCH-2160] #1435

Closed
spring-projects-issues opened this issue Jan 8, 2014 · 2 comments
Labels
in: infrastructure status: duplicate Issues that are duplicates of other issues type: enhancement

Comments

@spring-projects-issues
Copy link
Collaborator

Carl Holmes opened BATCH-2160 and commented

Spring 3 introduces a "ConversionService" to its data binders, allowing for type-safe conversions of data types to each other, in preference to the previous support for PropertyEditors. Converters and/or Formatters may be threadsafe, whereas PropertyEditors were never threadsafe.

It would be trivial to add a setter for a ConversionService and alter the method createBinder to perform the following line (assuming the ConversionService field is named simply "conversionService"):

binder.setConversionService(conversionService);

This will allow for easy conversion of common types (such as JodaType types with the formatter annotations) when processed via Spring Batch.


Affects: 2.2.1

1 votes, 3 watchers

@spring-projects-issues
Copy link
Collaborator Author

Pavlo commented

hey guys, it is hard to make CustomDateEditor thread-safe, can you add conversionService ?

@spring-projects-issues
Copy link
Collaborator Author

Michael Minella commented

We have a PR for this that states it's addressing BATCH-2529. I'm closing this one as a dupe in favor of that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: infrastructure status: duplicate Issues that are duplicates of other issues type: enhancement
Projects
None yet
Development

No branches or pull requests

1 participant