-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IllegalArgumentException thrown from afterPropertiesSet where IllegalStateException would be more appropriate #2244
Comments
Dave Syer commented Agree. And the problem is fairly ubiquitous in afterPropertiesSet() methods. Maybe the change can be scripted? |
Robert Kasanicky commented Maybe we should switch to using |
Dave Syer commented I don't like |
Mahmoud Ben Hassine commented @Iwein Fuld I also agree. However, there are some places in the code base that use |
Consistently use Assert.state in the afterPropertiesSet() methods to throw IllegalStateException instead of IllegalArgumentException when some properties are missing and/or invalid. Issue spring-projects#2244
Hi, I opened PR #4055 to address this issue. |
Iwein Fuld opened BATCH-1337 and commented
Should use Assert.state instead imo.
Affects: 2.0.1
The text was updated successfully, but these errors were encountered: