BATCH-2317 Optimized JdbcPagingItemReader configuration for process indicator pattern #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indicator pattern Allow absence of sortKeys when saveState=false.
| @@ -209,6 +221,7 @@ public static String generateRowNumSqlQueryWithNesting(AbstractSqlPagingQueryPro | |||
| * @return the generated query | |||
| */ | |||
| public static String generateLimitJumpToQuery(AbstractSqlPagingQueryProvider provider, String limitClause) { | |||
| Assert.notEmpty(provider.getSortKeys(), "sortKeys must be specified for generating jumpToItem queries"); | |||
There was a problem hiding this comment.
generateJumpToItemQuery is actually never called from JdbcPagingItemReader, the reader repositions itself from the startAfterValues. Maybe the generateJumpToItemQuery can be removed or made deprecated in PagingQueryProvider and related classes?
|
I'm closing this because I don't think this is the right approach. I'll elaborate in the JIRA ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow absence of sortKeys when saveState=false.