Do not throw NPE for job instances without executions #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b instances without executions
If Spring Batch fails with a NPE, I consider this as a bug and not a feature. I edited the title accordingly. |
fmbenhassine
changed the title
fmbenhassine
added
has: backports
|
LGTM, rebased and merged as b6c3fb6. Thank you for your contribution! |
fmbenhassine
added
for: backport-to-4.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with Spring Cloud Dataflow, it does occasionally happen that the database contains batch job instances without any batch job executions. When launching an execution for such an instance, this currently leads to a
NullPointerException.See for example:
Spring Batch should handle such a situation more gracefully and throw an exception with a hint to the problem.