Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding steps to the “Flow” via “next”, the task no longer goes into loop execution #4477

Conversation

bio-engineer
Copy link

@bio-engineer bio-engineer commented Oct 28, 2023

When adding steps to the “Flow” via “next”, the task no longer goes into loop execution

Fixes #4432

The project is completed build. All tests were completed successful

@pivotal-cla
Copy link

@bio-engineer Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@bio-engineer Thank you for signing the Contributor License Agreement!

@fmbenhassine
Copy link
Contributor

Thank you for this PR! We have already an open PR #4475 with a similar fix. Can you please check if this is a duplicate? Thank you upfront.

@fmbenhassine fmbenhassine added the status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter label Oct 31, 2023
@bio-engineer
Copy link
Author

I looked at the specified merge request and made sure that it partially duplicates my logic.

The problem is that the number of changes made to it is too large to close Issue.

So I can't guarantee that the changes made (there) don't break other logic

@fmbenhassine
Copy link
Contributor

Thank you for your feedback. As #4475 includes the changes in this PR, I merged it (even though its scope is a bit larger than the initial issue, it does not introduce any regression while making the methods consistent).

I merged this PR as well as it adds a nice test in FlowJobBuilderTests 👍

Rebased and merged as 42dd144. Thank you for your contribution!

@fmbenhassine fmbenhassine removed the status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting a flow with Flow#next makes the first step execute twice
3 participants