Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataRowMapper in JdbcCursorItemReaderBuilder & JdbcPagingItemReaderBuilder #4585

Conversation

kjuyoung
Copy link
Contributor

@kjuyoung kjuyoung commented May 5, 2024

related issue : #4578

Motivation:

JdbcCursorItemReader<Foo> reader = new JdbcCursorItemReaderBuilder<Foo>()
        ...
	.rowMapper(new DataClassRowMapper<>(FooRecord.class))
        .build();

JdbcPagingItemReader<Foo> reader = new JdbcPagingItemReaderBuilder<Foo>()
        ...
	.rowMapper(new DataClassRowMapper<>(FooRecord.class))
        .build();

Modification:

  • Add dataRowMapper method that returns DataClassRowMapper as rowMapper in JdbcCursorItemReaderBuilder and JdbcPagingItemReaderBuilder
public JdbcCursorItemReaderBuilder<T> dataRowMapper(Class<T> mappedClass) {
	this.rowMapper = new DataClassRowMapper<>(mappedClass);

	return this;
}

Result:

@fmbenhassine
Copy link
Contributor

LGTM 👍 Rebased and merged as 2d67b7e. I just introduced a couple minor test and javadoc updates, b6c7e4a.

Thank you for your contribution!

natedanner pushed a commit to natedanner/spring-projects__spring-batch that referenced this pull request May 20, 2024
- Update Javadocs
- Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data class support in JdbcCursorItemReaderBuilder & JdbcPagingItemReaderBuilder
2 participants