Specify that log file endpoint's response is UTF-8 encoded

Closes gh-16189
spring-projects · Apr 2, 2019 · 02b24b6 · 02b24b6
1 parent 22c9364
commit 02b24b6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/...t-actuator/src/main/java/org/springframework/boot/actuate/logging/LogFileWebEndpoint.java b/...t-actuator/src/main/java/org/springframework/boot/actuate/logging/LogFileWebEndpoint.java
@@ -55,7 +55,7 @@ public LogFileWebEndpoint(Environment environment) {
 		this(environment, null);
 	}
 
-	@ReadOperation(produces = "text/plain")
+	@ReadOperation(produces = "text/plain; charset=UTF-8")
 	public Resource logFile() {
 		Resource logFileResource = getLogFileResource();
 		if (logFileResource == null || !logFileResource.isReadable()) {

diff --git a/.../java/org/springframework/boot/actuate/logging/LogFileWebEndpointWebIntegrationTests.java b/.../java/org/springframework/boot/actuate/logging/LogFileWebEndpointWebIntegrationTests.java
@@ -69,6 +69,7 @@ public void getRequestProducesResponseWithLogFile() {
 		TestPropertyValues.of("logging.file:" + this.logFile.getAbsolutePath())
 				.applyTo(context);
 		client.get().uri("/actuator/logfile").exchange().expectStatus().isOk()
+				.expectHeader().contentType("text/plain; charset=UTF-8")
 				.expectBody(String.class).isEqualTo("--TEST--");
 	}
 
@@ -77,7 +78,9 @@ public void getRequestThatAcceptsTextPlainProducesResponseWithLogFile() {
 		TestPropertyValues.of("logging.file:" + this.logFile.getAbsolutePath())
 				.applyTo(context);
 		client.get().uri("/actuator/logfile").accept(MediaType.TEXT_PLAIN).exchange()
-				.expectStatus().isOk().expectBody(String.class).isEqualTo("--TEST--");
+				.expectStatus().isOk().expectHeader()
+				.contentType("text/plain; charset=UTF-8").expectBody(String.class)
+				.isEqualTo("--TEST--");
 	}
 
 	@Configuration