Merge branch '2.2.x' into 2.3.x

Closes gh-23969
spring-projects · Oct 29, 2020 · 70d9602 · 70d9602
2 parents eb77a20 + e7eb773
commit 70d9602
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/...sor/src/main/java/org/springframework/boot/configurationprocessor/TypeElementMembers.java b/...sor/src/main/java/org/springframework/boot/configurationprocessor/TypeElementMembers.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2019 the original author or authors.
+ * Copyright 2012-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -74,7 +74,7 @@ private void process(TypeElement element) {
 	private void processMethod(ExecutableElement method) {
 		if (isPublic(method)) {
 			String name = method.getSimpleName().toString();
-			if (isGetter(method) && !this.publicGetters.containsKey(name)) {
+			if (isGetter(method) && !this.publicGetters.containsKey(getAccessorName(name))) {
 				this.publicGetters.put(getAccessorName(name), method);
 			}
 			else if (isSetter(method)) {

diff --git a/...java/org/springframework/boot/configurationprocessor/PropertyDescriptorResolverTests.java b/...java/org/springframework/boot/configurationprocessor/PropertyDescriptorResolverTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2019 the original author or authors.
+ * Copyright 2012-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -75,6 +75,10 @@ void propertiesWithJavaBeanHierarchicalProperties() throws IOException {
 					PropertyDescriptorResolver resolver = new PropertyDescriptorResolver(metadataEnv);
 					assertThat(resolver.resolve(type, null).map(PropertyDescriptor::getName)).containsExactly("third",
 							"second", "first");
+					assertThat(resolver.resolve(type, null).map(
+							(descriptor) -> descriptor.getGetter().getEnclosingElement().getSimpleName().toString()))
+									.containsExactly("HierarchicalProperties", "HierarchicalPropertiesParent",
+											"HierarchicalPropertiesParent");
 					assertThat(resolver.resolve(type, null)
 							.map((descriptor) -> descriptor.resolveItemMetadata("test", metadataEnv))
 							.map(ItemMetadata::getDefaultValue)).containsExactly("three", "two", "one");

diff --git a/...ava/org/springframework/boot/configurationsample/simple/HierarchicalPropertiesParent.java b/...ava/org/springframework/boot/configurationsample/simple/HierarchicalPropertiesParent.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2019 the original author or authors.
+ * Copyright 2012-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -33,7 +33,8 @@ public void setSecond(String second) {
 		this.second = second;
 	}
 
-	// Useless override
+	// Overridden properties should belong to this class, not
+	// HierarchicalPropertiesGrandparent
 
 	@Override
 	public String getFirst() {