Use request attribute if available for error message

Fixes gh-1762, gh-1731
spring-projects · Oct 27, 2014 · 7bac737 · 7bac737
1 parent e8b59b9
commit 7bac737
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/...gure/src/main/java/org/springframework/boot/autoconfigure/web/DefaultErrorAttributes.java b/...gure/src/main/java/org/springframework/boot/autoconfigure/web/DefaultErrorAttributes.java
@@ -75,6 +75,7 @@ public ModelAndView resolveException(HttpServletRequest request,
 
 	private void storeErrorAttributes(HttpServletRequest request, Exception ex) {
 		request.setAttribute(ERROR_ATTRIBUTE, ex);
+
 	}
 
 	@Override
@@ -120,7 +121,7 @@ private void addErrorDetails(Map<String, Object> errorAttributes,
 				addStackTrace(errorAttributes, error);
 			}
 		}
-		else {
+		if (error==null || errorAttributes.get("message")==null) {
 			Object message = getAttribute(requestAttributes,
 					"javax.servlet.error.message");
 			errorAttributes.put("message", message == null ? "No message available"

diff --git a/...src/test/java/org/springframework/boot/autoconfigure/web/DefaultErrorAttributesTests.java b/...src/test/java/org/springframework/boot/autoconfigure/web/DefaultErrorAttributesTests.java
@@ -118,6 +118,17 @@ public void servletMessage() throws Exception {
 		assertThat(attributes.get("message"), equalTo((Object) "Test"));
 	}
 
+	@Test
+	public void nullMessage() throws Exception {
+		this.request.setAttribute("javax.servlet.error.exception", new RuntimeException());
+		this.request.setAttribute("javax.servlet.error.message", "Test");
+		Map<String, Object> attributes = this.errorAttributes.getErrorAttributes(
+				this.requestAttributes, false);
+		assertThat(attributes.get("exception"),
+				equalTo((Object) RuntimeException.class.getName()));
+		assertThat(attributes.get("message"), equalTo((Object) "Test"));
+	}
+
 	@Test
 	public void unwrapServletException() throws Exception {
 		RuntimeException ex = new RuntimeException("Test");