Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make replication factor check opt-in #12222

Closed
snicoll opened this issue Feb 26, 2018 · 2 comments
Closed

Make replication factor check opt-in #12222

snicoll opened this issue Feb 26, 2018 · 2 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@snicoll
Copy link
Member

snicoll commented Feb 26, 2018

The current Kafka health indicator attempts to retrieve a replication factor regardless of the fact that the application uses transaction or not.

We should make that check opt-in.

See #11515 (comment)

and this commit we can't use as looking for properties is not really legit there and there might be many other ways for the user to configure that stuff anyway.

@snicoll snicoll added this to the 2.0.0 milestone Feb 26, 2018
@snicoll snicoll self-assigned this Feb 26, 2018
snicoll added a commit to snicoll/spring-boot that referenced this issue Feb 26, 2018
@snicoll snicoll changed the title Do not use replication factor if transactions are disabled Make replication factor check opt-in Feb 26, 2018
@snicoll
Copy link
Member Author

snicoll commented Feb 26, 2018

After discussing with @wilkinsona we decided to make that check opt-in due to the number of issues that's raising. I am working on a proposal.

/cc @garyrussell

snicoll added a commit to snicoll/spring-boot that referenced this issue Feb 26, 2018
@snicoll
Copy link
Member Author

snicoll commented Feb 26, 2018

We've been looking at this issue most of today and came to the conclusion it isn't mature enough for us to provide a health indicator out of the box. We'll revert it and reconsider this feature for a latter release.

@snicoll snicoll closed this as completed Feb 26, 2018
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed priority: normal type: bug A general bug labels Feb 26, 2018
@snicoll snicoll removed this from the 2.0.0 milestone Feb 26, 2018
@snicoll snicoll removed their assignment Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

No branches or pull requests

1 participant