-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make replication factor check opt-in #12222
Labels
status: declined
A suggestion or change that we don't feel we should currently apply
Comments
snicoll
added a commit
to snicoll/spring-boot
that referenced
this issue
Feb 26, 2018
snicoll
changed the title
Do not use replication factor if transactions are disabled
Make replication factor check opt-in
Feb 26, 2018
After discussing with @wilkinsona we decided to make that check opt-in due to the number of issues that's raising. I am working on a proposal. /cc @garyrussell |
snicoll
added a commit
to snicoll/spring-boot
that referenced
this issue
Feb 26, 2018
We've been looking at this issue most of today and came to the conclusion it isn't mature enough for us to provide a health indicator out of the box. We'll revert it and reconsider this feature for a latter release. |
snicoll
added
status: declined
A suggestion or change that we don't feel we should currently apply
and removed
priority: normal
type: bug
A general bug
labels
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current Kafka health indicator attempts to retrieve a replication factor regardless of the fact that the application uses transaction or not.
We should make that check opt-in.
See #11515 (comment)
and this commit we can't use as looking for properties is not really legit there and there might be many other ways for the user to configure that stuff anyway.
The text was updated successfully, but these errors were encountered: