Documented defaults for some server properties do not match runtime defaults

[wilkinsona]

For a number of properties, the default in the code and, therefore, in the generated metadata is zero or null. At runtime, such values are interpreted as meaning that the component's default should be used. An unwanted side-effect of this is that the default from the metadata that is shown in your IDE does not match the default that you'll get at runtime. We should align the defaults in the code and metadata with the runtime defaults and add tests to ensure that the two are kept in sync.

[wilkinsona]

This problem is broader than just server properties.

[snicoll]

I guess all the "bytes" type properties are covered by this one. When merging forward to master we should switch those to DataSize. Given we're approaching RC1 it would be nice to do this sooner than later.

[wilkinsona]

To keep the scope manageable, let's narrow this back down to focus on server properties. We can open separate issues for other areas of the codebase.

[snicoll]

This change unfortunately breaks the 1.5.xTomcat 7 support in a very subtle way. redirectContextRoot has now a default value, which means that we're going to invoke the customizer no matter what and that method is not available on Tomcat 7.

[wilkinsona]

😬