Add first class support for disabling logback ConsoleAppender #1612
Comments
|
See the following for one such approach that doesnt require adding janino as a dependecy due to conditional configuration: http://stackoverflow.com/questions/23651466/overriding-logback-configurations |
|
I'd actually like to have the opposite (be able to disable the FILE appender). I also think that we should disable the FILE appender by default in 1.2 (implying that it can be switched on externally), so let's try and do all of those things in one ticket? |
|
Sounds great, thanks! |
dsyer
added
the
status: ideal-for-contribution
|
Curious as to your thoughts on how DW handles logging:
Basically they make it possible to configure everything in their |
|
We allow log levels to be configured in application.yml (.properties), but that works for all log providers. I think that and the location of log files are by far the most common things to change (if you don't like the Boot defaults for format you might add a logback.xml once and never have to change it), so that seems like a good balance to me. So I like it the way it is. |
1 disable the file output unless LOG_FILE is set 2 make the console optional fixes: spring-projectsgh-1612
1 disable the file output unless LOG_FILE is set 2 make the console optional fixes: spring-projectsgh-1612
1 disable the file output unless LOG_FILE is set 2 make the console optional fixes: gh-1612
philwebb
removed
the
status: ideal-for-contribution
Prior to this commit LoggingSystem initialization would happen multiple
times. Once to configure "quiet" logging, and again to configure correct
settings once the Application was initialized. This could cause problems
if `logging.groovy` logback files were used.
The logging system is now only initialized once (when possible) by
following these steps:
- Standard logging initialization occurs via the actual logging
implementation used (e.g. logback will load a logback.xml file if it
exists)
- beforeInitization() is called to prevent early log output.
Implementations now either use a Filter or simply set the root logging
level.
- initialize() is called with an optional log configuration file (e.g
a custom logback.xml location) and an optional log output file (the
default is null indicating console only output).
The initialize() method will attempt to prevent double initialization
by checking if a standard configuration file exists. Double
initialization now only occurs in the following situations:
- The user has a standard configuration file (e.g. classpath:logback.xml)
but also specifies a logging.config property. Double initialization is
required since the specified configuration file supersedes the default.
- The user has a standard configuration file (e.g. classpath:logback.xml)
and specifies a logging.file property. Double initialization is
required since the standard configuration may use a ${LOG_FILE}
reference.
In addition this commit removes the `logging.console` option and now
assumes that logging either occurs only to console or to both the
console and a file. This restriction helps simplify the LoggingSystem
implementations. If file only logging is required a custom logback.xml
can be used.
Fixes gh-1091
See gh-1612, gh-1770
philwebb
added
the
status: declined
|
Unfortunately I think adding a |
|
+1 |
It would be nice not to have to redefine the
logback.xmljust to disableCONSOLE. Could we do this with a standard property likelogging.console? Please see http://stackoverflow.com/questions/26019350/how-to-disable-logback-consoleappender-in-spring-boot/26019508?noredirect=1#comment40754570_26019508 for more detailsThe text was updated successfully, but these errors were encountered: