Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate fat jar unpack options #16197

Closed
philwebb opened this issue Mar 11, 2019 · 5 comments
Closed

Investigate fat jar unpack options #16197

philwebb opened this issue Mar 11, 2019 · 5 comments
Assignees

Comments

@philwebb
Copy link
Member

philwebb commented Mar 11, 2019

There's always going to be a certain overhead with our fat jar format so we should investigate what works best in terms of running an unpacked jar. This might overlap a little with #12545.

We should consider:

  • Do users want a zip from the build, or do they want to convert a fat jar
  • What happens with the embedded startup scripts
  • How does it effect PaaS and K8S deployments
  • How do we not overwhelm users with too much choice
@philwebb philwebb added the status: waiting-for-triage An issue we've not yet triaged label Mar 11, 2019
@vpavic
Copy link
Contributor

vpavic commented Jun 18, 2019

Couldn't we have the task that builds the fat jar split in two stages - one that prepares fat jar contents in the build work directory, and other that does the actual assembly?

That way if someone wants to package the application into a Docker image, or something else, they'd need to simply run the prepare task. That seems much more optimal than unpacking.

I should note that these days I mostly use Jib, so I don't have a pressing need for this, but for some advanced scenario I'd still have interest in such arrangement.

@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 20, 2019
@philwebb philwebb added this to the 2.3.x milestone Dec 20, 2019
@philwebb philwebb self-assigned this Jan 17, 2020
@philwebb philwebb modified the milestones: 2.3.x, 2.3.0.M4 Apr 2, 2020
@philwebb philwebb removed the type: enhancement A general enhancement label Apr 3, 2020
@philwebb
Copy link
Member Author

philwebb commented Apr 3, 2020

We think layertools should cover unpack needs for most users.

@philwebb philwebb closed this as completed Apr 3, 2020
@nngo
Copy link

nngo commented Apr 3, 2020

@philwebb can you provide a link to layertools with instructions on how it covers the unpack needs?

@wilkinsona
Copy link
Member

There's some information in the reference documentation.

@nngo
Copy link

nngo commented Apr 3, 2020

@wilkinsona Thanks for pointing to the new "Building Docker Image" section 31 added to the 2.3.x milestone reference docs > Spring Boot Features > Building Docker Images > Layering Docker Images.
I also just found this Creating Docker images with Spring Boot 2.3.0.M1 blog post on Jan 27, 2020 by @philwebb : https://spring.io/blog/2020/01/27/creating-docker-images-with-spring-boot-2-3-0-m1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants