-
Notifications
You must be signed in to change notification settings - Fork 40.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude correct HikariCP version #16489
Comments
Is this open for contribution? I would be happy to contribute if @pse-sonic don't mind |
Feel free to solve this issue :) |
@ielatif fixing the issue is easy but I'd like to put something in place so that our build fails the next time this happens. If you want to give that a try, feel free to go ahead. |
@ielatif it's already using HikariCP most probably. If you managed to reproduce the error in a test, feel free to submit something. |
Additionally the project should really set up a duplicate classpath check for a maximum possible amount of dependencies (all starters for example). |
Is there a workaround for this issue, or should I stay on 2.1.3? |
You can exclude the dependency yourself in your project for the time being. |
PR #16502 |
Closing in favour of PR #16502 |
For me this is not solved with 2.1.5 and quartz 2.3.1 - the startup still fails with the error. |
@oneiros-de This issue applied specifically to a |
I'm using latest springboot 2.3.2, and have the same issue mentioned above. With springboot 2.3.1 , I didn't get this error. implementation ('org.springframework.boot:spring-boot-starter-quartz') {
exclude group: 'com.zaxxer', module: 'HikariCP-java7'
// workaround for https://github.com/spring-projects/spring-boot/issues/16489
} Before this exclusion, I had the following dependencies:
I'm not sure if that is an issue related to Quartz or to SpringBoot... |
Thanks for letting us know, @oridool. This is a bug in the dependency management plugin that the changes made for #21911 have exposed. I've opened spring-gradle-plugins/dependency-management-plugin#281. |
Thank you @wilkinsona for the fast fix. |
Right. |
Hello,
Spring Boot 2.1.4-RELEASE uses Quartz 2.3.1 which contains hikaricp-java7 (since this release - see quartz-scheduler/quartz#294) but the spring-boot-dependencies POM still excludes hikaricp-java6.
This causes an AbstractMethodError when using HikariCP and Quartz together.
Caused by: java.lang.AbstractMethodError: Receiver class com.zaxxer.hikari.metrics.micrometer.MicrometerMetricsTrackerFactory does not define or inherit an implementation of the resolved method abstract create(Ljava/lang/String;Lcom/zaxxer/hikari/metrics/PoolStats;)Lcom/zaxxer/hikari/metrics/MetricsTracker; of interface com.zaxxer.hikari.metrics.MetricsTrackerFactory.
Best regards
Sebastian
The text was updated successfully, but these errors were encountered: