Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that auto-configuration classes and properties are considered internal #16704

Closed
philwebb opened this issue May 2, 2019 · 2 comments

Comments

@philwebb
Copy link
Member

commented May 2, 2019

No description provided.

@snicoll

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

@mbhave I wonder if that shouldn't be a bit more high level (in some dedicated section) that explains that extending from auto-configuration should be avoided, etc. I didn't understand why this was documented in the configuration properties section either.

@wilkinsona

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

We looked at this today, and concluded that what we currently have is fine. We consider not sub-classing to be a specific example of not relying anything other than the class's name which is already covered in the additions that have already been made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.