Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document adding multiple connectors for Jetty and Undertow #17144

Open
mbhave opened this issue Jun 13, 2019 · 4 comments
Open

Document adding multiple connectors for Jetty and Undertow #17144

mbhave opened this issue Jun 13, 2019 · 4 comments
Labels
type: documentation A documentation update
Milestone
General Backlog

Comments

@mbhave
Copy link
Contributor

mbhave commented Jun 13, 2019 •
edited

It's possible to add additional connectors on TomcatServletWebServerFactory. We should make that consistent unless there was a specific reason for not doing so on the reactive side.

Related #528.
@mbhave mbhave added the type: enhancement A general enhancement label Jun 13, 2019
@mbhave mbhave added this to the General Backlog milestone Jun 13, 2019
@philwebb philwebb mentioned this issue Jun 14, 2019
Closed
@wilkinsona wilkinsona changed the title Support adding multiple connectors for reactive tomcat Support adding multiple connectors for reactive Jetty, Tomcat, and Undertow Jun 14, 2019
@mbhave
Copy link
Contributor Author

mbhave commented Jun 14, 2019

For Jetty and Undertow this can be done with a JettyServerCustomizer and UndertowBuilderCustomizer respectively. We can use this issue to add support for Tomcat and document how to configure multiple connectors for all three.

htztomic added a commit to htztomic/spring-boot that referenced this issue Jun 25, 2019
@htztomic
Fixes to spring-projectsGH-17144
6f5d2b8
htztomic added a commit to htztomic/spring-boot that referenced this issue Jun 26, 2019
@htztomic
Fixes to spring-projectsGH-17144
b3abd1f
@htztomic htztomic mentioned this issue Jun 26, 2019
Closed
@mbhave mbhave changed the title Support adding multiple connectors for reactive Jetty, Tomcat, and Undertow Support adding multiple connectors for Jetty and Undertow Jun 26, 2019
@mbhave
Copy link
Contributor Author

mbhave commented Jun 26, 2019

The experience with Tomcat vs Jetty/Undertow is slightly inconsistent. With Tomcat you need to use the addAdditionalConnectors method. I don't think there's a way to add a connector without creating a new WebServerFactory. With Jetty and Undertow it's possible to do so via customizers.

We should try and make them all consistent.

@wilkinsona
Copy link
Member

wilkinsona commented Jun 27, 2019 •
edited

I don't think there's a way to add a connector without creating a new WebServerFactory.

It still wouldn't quite be consistent, but can't you use a WebServerFactoryCustomizer to avoid needing to create the factory?

@mbhave
Copy link
Contributor Author

mbhave commented Jun 27, 2019

oh yeah, you're right. Wonder if we should change this section of the doc to use the customizer then?

@mbhave mbhave changed the title Support adding multiple connectors for Jetty and Undertow Document adding multiple connectors for Jetty and Undertow Jun 27, 2019
@mbhave mbhave added type: documentation A documentation update and removed type: enhancement A general enhancement labels Jun 27, 2019
@Guy2You Guy2You mentioned this issue Nov 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: documentation A documentation update
Projects
None yet
Milestone
General Backlog
Development

No branches or pull requests
3 participants
@wilkinsona @mbhave @mhalbritter