Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ManagementWebServerFactoryCustomizer should not always add ErrorPage #17951

Closed
philwebb opened this issue Aug 23, 2019 · 2 comments
Closed

ManagementWebServerFactoryCustomizer should not always add ErrorPage #17951

philwebb opened this issue Aug 23, 2019 · 2 comments
Labels
status: duplicate A duplicate of another issue

Comments

@philwebb
Copy link
Member

Currently ManagementWebServerFactoryCustomizer always adds an ErrorPage, however, in Jersey applications we don't have an endpoint for them so the application returns 404 for all errors. We should probably mirror ErrorMvcAutoConfiguration.ErrorPageCustomizer somehow and only register them for MVC.
@philwebb philwebb added the type: bug A general bug label Aug 23, 2019
@philwebb philwebb added this to the 2.1.x milestone Aug 23, 2019
@philwebb
Copy link
Member Author

See #17912

@mbhave
Copy link
Contributor

mbhave commented Aug 24, 2019

@philwebb I think this is a duplicate of #17938

@philwebb philwebb added status: duplicate A duplicate of another issue and removed type: bug A general bug labels Aug 24, 2019
@philwebb philwebb removed this from the 2.1.x milestone Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philwebb @mbhave