Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non MVC web applications always return 404 for errors #17938

Closed
mbhave opened this issue Aug 22, 2019 · 1 comment

Comments

@mbhave
Copy link
Contributor

commented Aug 22, 2019

This can be reproduced by adding spring security to SampleJerseyApplication and setting management.server.port to something other than 8080. The difference between the main application port and the management port is that there's an error page for the management context.

@philwebb

This comment has been minimized.

Copy link
Member

commented Aug 24, 2019

Currently ManagementWebServerFactoryCustomizer always adds an ErrorPage, however, in Jersey applications we don't have an endpoint for them so the application returns 404 for all errors. We should probably mirror ErrorMvcAutoConfiguration.ErrorPageCustomizer somehow and only register them for MVC.

@philwebb philwebb changed the title 404 for protected actuator endpoints on Jersey application with separate management port ManagementWebServerFactoryCustomizer should not always add ErrorPage Aug 24, 2019
@philwebb philwebb changed the title ManagementWebServerFactoryCustomizer should not always add ErrorPage Non MVC web applications always return 404 for errors Aug 26, 2019
@philwebb philwebb closed this in 4c446c3 Aug 26, 2019
@snicoll snicoll modified the milestones: 2.1.x, 2.1.8 Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.