Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Maven Resolver 1.4.1 #18454

Closed
snicoll opened this issue Oct 1, 2019 · 3 comments
Closed

Upgrade to Maven Resolver 1.4.1 #18454

snicoll opened this issue Oct 1, 2019 · 3 comments
Labels
type: dependency-upgrade A dependency upgrade
Milestone
2.3.0.M1

Comments

@snicoll
Copy link
Member

snicoll commented Oct 1, 2019

No description provided.

@snicoll snicoll added the type: dependency-upgrade A dependency upgrade label Oct 1, 2019
@snicoll snicoll added this to the 2.2.0.RC1 milestone Oct 1, 2019
@snicoll
Copy link
Member Author

snicoll commented Oct 1, 2019

Looks like that upgrading means we need to add a SLF4J binding to the CLI. It might be a bit late to look at that so flagging for team attention to see what the rest of the team thinks.

@snicoll snicoll added for: team-attention An issue we'd like other members of the team to review and removed for: team-attention An issue we'd like other members of the team to review labels Oct 1, 2019
@snicoll snicoll modified the milestones: 2.2.0.RC1, 2.x Oct 1, 2019
@snicoll snicoll modified the milestones: 2.x, 2.3.x Oct 15, 2019
snicoll added a commit to snicoll/spring-boot that referenced this issue Dec 30, 2019
@snicoll
Update to Maven Resolver 1.4.1
88c18fe 
Closes spring-projectsgh-18454
@snicoll
Copy link
Member Author

snicoll commented Dec 30, 2019

We discussed it and I forgot what the outcome was. This requires adding an slf4j implementation on the classpath for the CLI. I am not sure what to do. I've added slf4j-simple but given that our codebase uses JCL, I wonder if we shouldn't do something else. Flagging again for team attention.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Dec 30, 2019
@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Jan 16, 2020
@philwebb philwebb modified the milestones: 2.3.x, 2.3.0.M1 Jan 16, 2020
@philwebb
Copy link
Member

Looks like this was fixed during the Gradle migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
2.3.0.M1
Development

No branches or pull requests
2 participants
@snicoll @philwebb