Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support commas embedded in command line arguments from Maven plugin #18688

Closed
dsyer opened this issue Oct 22, 2019 · 2 comments
Closed

Support commas embedded in command line arguments from Maven plugin #18688

dsyer opened this issue Oct 22, 2019 · 2 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@dsyer
Copy link
Member

dsyer commented Oct 22, 2019

It's actually impossible (as far as I can tell) to specify a command line argument that has a comma embedded in it. The comma is swallowed by Maven and turned into a value separator.

E.g.

$ mvn spring-boot:run -Dspring-boot.run.arguments='--management.endpoints.web.exposure.include=prometheus,info,health,metrics'

only exposes one endpoint.

Other Maven plugins seem to make configuration properties of type String and parse them out to a String[] manually. Example: http://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#locales. We would have to document an escape sequence, or alternative separator.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 22, 2019
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 22, 2019
@philwebb philwebb added this to the 2.2.x milestone Oct 22, 2019
@philwebb
Copy link
Member

I think we should consider this a bug, but I'm worried it might involve making a breaking change. I'll target it to 2.2.x for now.

nosan added a commit to nosan/spring-boot that referenced this issue Oct 23, 2019
@nosan
Add support commas embedded in command line arguments from Maven plugin.
058c50d 
see spring-projectsgh-18688
@nosan nosan mentioned this issue Oct 23, 2019
Closed
nosan added a commit to nosan/spring-boot that referenced this issue Oct 23, 2019
@nosan
Support commas embedded in command line arguments from Maven plugin
ef06c2f 
See spring-projectsgh-18688
@philwebb
Copy link
Member

Closing in favor of PR #18711

@philwebb philwebb added status: superseded An issue that has been superseded by another and removed type: bug A general bug labels Oct 23, 2019
@philwebb philwebb removed this from the 2.2.x milestone Oct 23, 2019
nosan added a commit to nosan/spring-boot that referenced this issue Oct 24, 2019
@nosan
Support commas embedded in command line arguments from Maven plugin
a356d6a 
See spring-projectsgh-18688
nosan added a commit to nosan/spring-boot that referenced this issue Oct 25, 2019
@nosan
Support commas embedded in command line arguments from Maven plugin
79377a6 
See spring-projectsgh-18688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dsyer @philwebb @spring-projects-issues