-
Notifications
You must be signed in to change notification settings - Fork 40.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HazelcastClientFactory can return null instead of HazelcastInstance if there is no HazelcastClient for the given name #19709
Labels
Comments
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Jan 14, 2020
Dmytro and I already chatted about that offline so it's all good from my perspective. We should add a test that exercises the new behaviour as part of fixing this. |
wilkinsona
added
type: bug
A general bug
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Jan 14, 2020
wilkinsona
added
the
status: blocked
An issue that's blocked on an external project change
label
Jan 14, 2020
Fixing this would require Hazelcast |
nosan
added a commit
to nosan/spring-boot
that referenced
this issue
Feb 4, 2020
…f there is no HazelcastClient for the given name Closes spring-projectsgh-19709
nosan
added a commit
to nosan/spring-boot
that referenced
this issue
Feb 9, 2020
…f there is no HazelcastClient for the given name Closes spring-projectsgh-19709
Closing in favour of PR #20109 |
snicoll
added
status: superseded
An issue that has been superseded by another
and removed
status: blocked
An issue that's blocked on an external project change
labels
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Hello,
When I was working on #19669 I found that
HazelcastAutoConfiguration
may create aNullBean
instead ofHazelcastInstance
.When
HazelcastClientFactory
tries to find theHazelcastInstance
by name and there is no instance with that name, thenull
will be returned. It happens only whenClientConfig
has an instance's name.Test to reproduce:
The test fails due to:
This issue can be fixed with a new method which was provided by Hazelcast (hazelcast/hazelcast#16362), there is also a back-port (hazelcast/hazelcast#16363), so that method should be available in Hazelcast 3.12.6
My idea is change
HazelcastClient.getHazelcastClientByName(Name)
toHazelcastClient. getOrCreateHazelcastClient(Config)
inHazelcastClientFactory
when a new version ofHazelcast
will be released.The text was updated successfully, but these errors were encountered: