Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Reactor Californium-SR16 #20196

Closed
wilkinsona opened this issue Feb 15, 2020 · 1 comment
Closed

Upgrade to Reactor Californium-SR16 #20196

wilkinsona opened this issue Feb 15, 2020 · 1 comment
Assignees
Labels
type: dependency-upgrade A dependency upgrade
Milestone

Comments

@wilkinsona
Copy link
Member

No description provided.

@wilkinsona wilkinsona added the type: dependency-upgrade A dependency upgrade label Feb 15, 2020
@wilkinsona wilkinsona added this to the 2.1.13 milestone Feb 15, 2020
@wilkinsona
Copy link
Member Author

wilkinsona commented Feb 19, 2020

Current Californium snapshots cause a test in spring-boot-actuator to fail:

[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   CachingOperationInvokerTests.cacheInTtlWithFluxResponse:94 expected:<[1]> but was:<[2]>
[INFO] 
[ERROR] Tests run: 963, Failures: 1, Errors: 0, Skipped: 0

It appears that Flux caching doesn't work. The following pure Reactor test passes with SR-15 but fails with the current BUILD-SNAPSHOT of Californium:

@Test
public void fluxCaching() {
    AtomicInteger invocations = new AtomicInteger();
    Flux<String> flux = Flux.fromIterable(() -> {
        invocations.incrementAndGet();
        return Arrays.asList("spring", "boot").iterator();
    }).cache(Duration.ofHours(1));
    assertThat(flux.blockLast()).isEqualTo("boot");
    assertThat(flux.blockLast()).isEqualTo("boot");
    assertThat(invocations).hasValue(1);
}

The test fails because the value of invocations is two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

No branches or pull requests

1 participant