-
Notifications
You must be signed in to change notification settings - Fork 40.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching default to include layers index for fat jar #20983
Comments
We'd need a Gradle API to switch off support. Since this is quite late for 2.3, we'll reassess in 2.4 |
We also need to decide whether we should include the layertools classes to the fat jar, or just the idx file. |
Looking at #22195 caused me to notice that there are a few places in the Gradle plugin, javadoc for example, where it reads as if layers are disabled by default. Re-opening so that we can address those. |
It seems that both layers.idx and layertools are included in the fat jar by default now. You can only exclude the layertools from the jar explicitly. I know that layertools isn't that big, but in this case should this be included with the launcher? I'm a bit confused by this situation. |
I thought it made sense to include layertools by default if layers.idx was present by default as well. I'm not sure what you mean by
but we can discuss this on the next call. |
The use case we want to promote is CNB and our build image build integration. This does not require layertools so that seems a bit strange to include it by default. This would break users creating docker image and relying on that when upgrading to 2.3 but they'd have to change the |
We've discussed this and we concluded that offering a good out-of-the-box experience for both CNB users (via our build image task in the Maven and Gradle plugins) as well as those who prefer to craft their |
No description provided.
The text was updated successfully, but these errors were encountered: