Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop auto-configuring ReactiveNeo4jTransactionManager #22940

Closed
snicoll opened this issue Aug 13, 2020 · 1 comment
Closed

Stop auto-configuring ReactiveNeo4jTransactionManager #22940

snicoll opened this issue Aug 13, 2020 · 1 comment
Assignees
Labels
type: task A general task
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Aug 13, 2020

This is a sub-set of #22851 and a workaround for the time being.

Our current arrangement with Neo4j means that, as soon as reactor is on the classpath, the auto-configuration creates both a PlatformTransactionManager and a ReactiveTransactionManager. The core framework does not support such arrangement with a qualifier on @Transactional which is not something we should expect to happen out-of-the-box.

Until we figure out what to do in #22851, we're going to remove auto-configuration for the reactive transaction manager. This helps existing users test the 2.4 milestones (as the reactive support is new) and is reasonable that you have to create your own transaction manager if you want to use imperative access.

Hopefully, a future milestone of the 2.4 line will provide a better user experience for this use case.

@snicoll snicoll added the type: task A general task label Aug 13, 2020
@snicoll snicoll added this to the 2.4.0-M2 milestone Aug 13, 2020
@snicoll snicoll self-assigned this Aug 13, 2020
@snicoll
Copy link
Member Author

snicoll commented Aug 13, 2020

I've updated the release notes to mention that limitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant