Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring-boot-gradle-plugin docs use deprecated Gradle API #29610

Closed
halcyon22 opened this issue Feb 1, 2022 · 2 comments
Closed

spring-boot-gradle-plugin docs use deprecated Gradle API #29610

halcyon22 opened this issue Feb 1, 2022 · 2 comments
Labels
status: superseded An issue that has been superseded by another type: documentation A documentation update

Comments

@halcyon22
Copy link
Contributor

The Spring Boot Gradle Reference Guide uses AbstractArchiveTask.classifier which is deprecated as of Gradle 5.1 and replaced by archiveClassifier. As the plugin requires Gradle 6.8, 6.9, or 7.x, the example should be updated.

https://github.com/spring-projects/spring-boot/blob/main/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/docs/gradle/packaging/boot-jar-and-jar-classifiers.gradle

bootJar {
    archiveClassifier = 'boot'
}

jar {
    archiveClassifier = ''
}

https://github.com/spring-projects/spring-boot/blob/main/spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/src/docs/gradle/packaging/boot-jar-and-jar-classifiers.gradle.kts

tasks.getByName<BootJar>("bootJar") {
    archiveClassifier.set("boot")
}

tasks.getByName<Jar>("jar") {
    archiveClassifier.set("")
}

I can create a PR for this change if preferred.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 1, 2022
@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 1, 2022
@snicoll snicoll added this to the 2.5.x milestone Feb 1, 2022
@snicoll
Copy link
Member

snicoll commented Feb 1, 2022

@halcyon22 thank you for the report. If you have time for a PR, that would be much appreciated.

@snicoll
Copy link
Member

snicoll commented Feb 1, 2022

Closing in favor of PR #29611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

3 participants