Skip to content

In Gradle plugin docs, replace classifier (deprecated) with archiveClassifier in examples #29611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

halcyon22
Copy link
Contributor

The Spring Boot Gradle Reference Guide uses AbstractArchiveTask.classifier which is deprecated as of Gradle 5.1 and replaced by archiveClassifier. As the plugin requires Gradle 6.8, 6.9, or 7.x, the example should be updated.

Originally submitted as #29610.

@pivotal-cla
Copy link

@halcyon22 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 1, 2022
@pivotal-cla
Copy link

@halcyon22 Thank you for signing the Contributor License Agreement!

@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 1, 2022
@snicoll snicoll added this to the 2.5.x milestone Feb 1, 2022
@wilkinsona
Copy link
Member

Our GradleBuild test help asserts that a build hasn't generated any unexpected deprecation warnings. This test should have failed due to that assertion. As part of merging this, we should understand why the test didn't fail and fix it.

@wilkinsona wilkinsona added the for: merge-with-amendments Needs some changes when we merge label Feb 1, 2022
@wilkinsona
Copy link
Member

The tests aren't failing as Gradle doesn't log a deprecation warning. This means that there's nothing for us to fix. I've reached out to the Gradle team to see if this is something that they might want to change on their side.

@wilkinsona wilkinsona removed the for: merge-with-amendments Needs some changes when we merge label Feb 9, 2022
@wilkinsona wilkinsona changed the title In spring-boot-gradle-plugin docs, replace classifier (deprecated) with archiveClassifier in examples In Gradle plugin docs, replace classifier (deprecated) with archiveClassifier in examples Feb 9, 2022
@wilkinsona
Copy link
Member

With thanks to @ljacomet, the lack of deprecation warnings is intentional as the API's called by Kotlin's Gradle plugin.

@wilkinsona wilkinsona modified the milestones: 2.5.x, 2.5.10 Feb 9, 2022
wilkinsona pushed a commit that referenced this pull request Feb 9, 2022
classifier has been deprecated so the docs should be using its
replacement, archiveClassifier, instead.

See gh-29611
@wilkinsona wilkinsona closed this in 3a5bf49 Feb 9, 2022
@wilkinsona
Copy link
Member

@halcyon22 Thanks very much for making your first contribution to Spring Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants