Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop relying on inject-api rebundled by AppEngine #29990

Closed
snicoll opened this issue Feb 24, 2022 · 0 comments
Closed

Stop relying on inject-api rebundled by AppEngine #29990

snicoll opened this issue Feb 24, 2022 · 0 comments
Assignees
@snicoll
Labels
type: task A general task
Milestone
2.5.11

Comments

@snicoll
Copy link
Member

snicoll commented Feb 24, 2022

As reveled by #29984, spring-boot tests rely on the present of inject-api that turns out to be provided by a repackage version in AppEngine. We should rather add an explicit dependency for this.
@snicoll snicoll added the type: task A general task label Feb 24, 2022
@snicoll snicoll added this to the 2.5.10 milestone Feb 24, 2022
@snicoll snicoll self-assigned this Feb 24, 2022
@snicoll snicoll modified the milestones: 2.5.10, 2.5.11 Feb 24, 2022
@snicoll snicoll mentioned this issue Feb 24, 2022
Closed
mhalbritter pushed a commit to mhalbritter/spring-boot that referenced this issue Feb 28, 2022
@snicoll @mhalbritter
Add explicit dependency on inject-api
5a295c4 
This commit clarifies the build as a test needs inject-api and it works
only by side effect as another library has repackaged this API.

Closes spring-projectsgh-29990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
2.5.11
Development

No branches or pull requests
1 participant
@snicoll