Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating Jackson dependency for Boot 2.5.10 due to CVE-2020-36518 #30354

Closed
ghillert opened this issue Mar 21, 2022 · 3 comments
Closed
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@ghillert
Copy link

In Spring Boot 2.5.10, spring-boot-starter-json depends on jackson-databind version 2.12.6. Dependency-Check 7.0.0 will flag this with a high CVSS score - CVE-2020-36518.

Related issue: FasterXML/jackson-databind#2816

[ERROR] Failed to execute goal org.owasp:dependency-check-maven:7.0.0:check (default) on project jackson-demo:
[ERROR]
[ERROR] One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '7.0':
[ERROR]
[ERROR] jackson-databind-2.12.6.jar: CVE-2020-36518(7.5)

This issue does not affect Spring Boot 2.6.4 and I do understand that it is advisable to upgrade ASAP to that version. But since the 2.5.x branch is still supported, I wanted to raises this issue for completeness.

Demo project to reproduce the issue: https://github.com/ghillert/boot-jackson-cve/tree/main

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 21, 2022
@wilkinsona
Copy link
Member

We won’t upgrade to a new minor version of a dependency in a maintenance release of Spring Boot. You can either upgrade to Spring Boot 2.6.x or stick with 2.5.x and use the jackson.version property to opt in to the upgrade.

@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 22, 2022
@alexsheppard11
Copy link

2.12.6.1 has been released to fix this CVE FasterXML/jackson-databind#2816 (comment) . Will you consider a patch release of 2.5.x now?

@snicoll
Copy link
Member

snicoll commented Mar 29, 2022

@alexsheppard11 there is no need to ask. As mentioned on several occasions, we have a semi-automated upgrade process that will upgrade dependencies to whatever match our 3rd party upgrade policy. And there is no need to wait for us releasing as you can use the jackson.version as described above already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

No branches or pull requests

5 participants