Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to make them compatible with Java 19 #32280

Closed
wilkinsona opened this issue Sep 9, 2022 · 0 comments
Closed

Update tests to make them compatible with Java 19 #32280

wilkinsona opened this issue Sep 9, 2022 · 0 comments
Assignees
@wilkinsona
Labels
type: task A general task
Milestone
2.6.12

Comments

@wilkinsona
Copy link
Member

A small number of our tests don't run on Java 19 for a few different reasons:

  • Mockito's partial mocking doesn't work on Java 19 when the mocked interface has default methods
  • We can't mock InetAddress any more as it's sealed in Java 19
  • Thread dumps describe held locks slightly differently
@wilkinsona wilkinsona added the type: task A general task label Sep 9, 2022
@wilkinsona wilkinsona added this to the 2.6.x milestone Sep 9, 2022
@wilkinsona wilkinsona self-assigned this Sep 9, 2022
@wilkinsona wilkinsona mentioned this issue Sep 9, 2022
Closed
@wilkinsona wilkinsona modified the milestones: 2.6.x, 2.6.12 Sep 10, 2022
wilkinsona added a commit that referenced this issue Sep 10, 2022
@wilkinsona
Only disable test tasks when a project isn't compatible with toolchain
5cb23ae 
Disabling compilation means that any downstream project will break.
For example, disabling our Gradle plugin's compileJava task means
that the launch script test app fails to build as it uses our
Gradle plugin and its classes are missing.

See gh-gh-32280
wilkinsona added a commit that referenced this issue Sep 10, 2022
@wilkinsona
Disable LoaderIntegrationTests on Java 19 till it GAs
a262520 
See gh-32280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: task A general task
Projects
None yet
Milestone
2.6.12
Development

No branches or pull requests
1 participant
@wilkinsona