Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to Micrometer's BraveBaggageManager changes #38724

Closed
mhalbritter opened this issue Dec 11, 2023 · 2 comments
Closed

Adapt to Micrometer's BraveBaggageManager changes #38724

mhalbritter opened this issue Dec 11, 2023 · 2 comments
Labels
status: invalid An issue that we don't feel is valid

Comments

@mhalbritter
Copy link
Contributor

We need to pass a list of tags into the BraveBaggageManager constructor to keep tagged baggage fields working.

See micrometer-metrics/tracing#375 (comment)
@mhalbritter mhalbritter added type: task A general task theme: observability Issues related to observability labels Dec 11, 2023
@mhalbritter mhalbritter added this to the 3.2.x milestone Dec 11, 2023
@mhalbritter mhalbritter mentioned this issue Dec 11, 2023
Closed
@mhalbritter
Copy link
Contributor Author

As we currently don't support tagged baggage (neither in Otel nor with Brave), we don't need to do anything here.

@mhalbritter mhalbritter closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
@mhalbritter mhalbritter added status: invalid An issue that we don't feel is valid and removed type: task A general task theme: observability Issues related to observability labels Dec 11, 2023
@mhalbritter mhalbritter removed this from the 3.2.x milestone Dec 11, 2023
@mhalbritter mhalbritter mentioned this issue Dec 11, 2023
Closed
mhalbritter added a commit that referenced this issue Jan 9, 2024
@mhalbritter
Adapt to changes in Brave tagged fields handling
7120dc0 
See gh-38724

See gh-37435
@mhalbritter
Copy link
Contributor Author

I've refined our usage of BraveBaggageManager while merging #37435.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhalbritter