Whitelabel error page doesn't display when deployed to Tomcat server

[ukdave]

I've got a basic spring boot webapp and I'm trying to create a customised error page for it.

I'm using spring-boot-actuator so I've got its default whitelabel error page and have successfully customised it by creating my own error.html page. This is working nicely when running with the embedded Tomcat container - if one of my controllers throws an exception (e.g. DataAccessException) then my custom error page gets displayed. However, when I deploy my app to a Tomcat server I get the default Tomcat error page showing the full stack trace.

I've been trying to trace what's going on using the debugger in STS and I've found the ErrorPageFilter (which only seems to be present when running on the Tomcat server) is correctly handling the exception and forwarding the request to the error controller. However tracing further I eventually get to the invoke method of org.apache.catalina.valves.ErrorReportValve which seems to then reset the response.

I'm using Spring Boot 1.0.1.RELEASE and Apache Tomcat 7.0.53.

[hoserdude]

Saw this as well - after the fix the custom page comes back as a 200, should the ErrorPageFilter also set the Response status to 500 (or whatever?). I added response.setStatus(HttpStatus.INTERNAL_SERVER_ERROR.value()); just before the wrapped.sendError(500, ex.getMessage()) call and that seemed to do the trick. Alternatively the BasicErrorController could do the equivalent before it returns the view. What do you guys think?

[dsyer]

I assume in a JAR deployment you get a 500 (in which case if you make a change it should go in the filter)?

See also #538 (which when fixed will include generic error handling for all >=400 errors), which is down for 1.1 because it's quite a big change. Maybe better to wait till that is finished before changing anything?

[hoserdude]

Sounds good, my custom ErrorController takes care of this for now.

[sarpk]

I still have the same issue that hoserdude had in 2014.

The bad thing about hoserdude's solution is say if the response was something else apart from 500 then you would still return 500. So I want to prevent that happening. ie not much point showing 500 error when the actual response is 404.

[dsyer]

Thanks for your interest. It almost never helps to comment on an issue that was closed as resolved 2 years ago. It's unlikely that you are using the same code as was current then, but if you are just upgrade. Otherwise I would recommend opening a new issue or asking a question on stackoverflow if it's about usage.