Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrorPageFilter: configurable logged message #7380

Closed
stephanedaviet opened this issue Nov 14, 2016 · 1 comment
Closed

ErrorPageFilter: configurable logged message #7380

stephanedaviet opened this issue Nov 14, 2016 · 1 comment
Labels
type: enhancement A general enhancement
Milestone
1.5.0 RC1

Comments

@stephanedaviet
Copy link

Currently, ErrorPageFilter only logs the path of the request without the query string. This part of the message is obtained by a call to ErrorPageFilter#getDescription. There's no way for customization or extensibility at this place, the method is private.

It would be great to be able to customize this message without having to proceed to a full rewrite of ErrorPageFilter to a homemade custom filter class.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 14, 2016
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 14, 2016
@philwebb
Copy link
Member

I don't see any problem with making that method protected.

@philwebb philwebb added this to the 1.5.0 M1 milestone Nov 14, 2016
stephanedaviet pushed a commit to stephanedaviet/spring-boot that referenced this issue Nov 15, 2016
Fix spring-projects#7380 ErrorPageFilter logging customization
5cd8fbb 
Make ErrorPageFilter#getDescription protected instead of private to be
able to customize the details for the request logged in case of error
(currently, only request path is logged).
philwebb pushed a commit to philwebb/spring-boot that referenced this issue Nov 16, 2016
@philwebb
Make ErrorPageFilter.getDescription protected
e22fe54 
Make `ErrorPageFilter#getDescription` `protected` instead of `private`
to be able to customize the details for the request logged in case of
an error.

Fixes spring-projectsgh-7380
Closes spring-projectsgh-7393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.5.0 RC1
Development

No branches or pull requests
3 participants
@philwebb @stephanedaviet @spring-projects-issues