Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Spring Data Kay M3 #7461

Closed
wilkinsona opened this issue Nov 23, 2016 · 6 comments
Closed

Upgrade to Spring Data Kay M3 #7461

wilkinsona opened this issue Nov 23, 2016 · 6 comments
Assignees
@wilkinsona
Labels
type: blocker An issue that is blocking us from releasing type: dependency-upgrade A dependency upgrade
Milestone
2.0.0.M1

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Nov 23, 2016 •
edited

#7465 will make this a bit easier
@wilkinsona wilkinsona added the type: enhancement A general enhancement label Nov 23, 2016
@wilkinsona wilkinsona added this to the 2.0.0.M1 milestone Nov 23, 2016
@wilkinsona wilkinsona self-assigned this Nov 23, 2016
@wilkinsona
Copy link
Member Author

This is blocked until Spring Session is compatible with Spring Data Kay. One failure that I've seen thus far is:

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'mongoSessionRepository': Invocation of init method failed; nested exception is java.lang.NoSuchMethodError: org.springframework.data.mongodb.core.IndexOperations.ensureIndex(Lorg/springframework/data/mongodb/core/index/IndexDefinition;)V
	at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor.postProcessBeforeInitialization(InitDestroyAnnotationBeanPostProcessor.java:137)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyBeanPostProcessorsBeforeInitialization(AbstractAutowireCapableBeanFactory.java:407)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1587)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:566)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:482)
	at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:304)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:300)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:195)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:744)
	at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:866)
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:542)
	at org.springframework.boot.autoconfigure.session.AbstractSessionAutoConfigurationTests.load(AbstractSessionAutoConfigurationTests.java:73)
	at org.springframework.boot.autoconfigure.session.SessionAutoConfigurationTests.mongoSessionStore(SessionAutoConfigurationTests.java:102)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:239)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:675)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)
Caused by: java.lang.NoSuchMethodError: org.springframework.data.mongodb.core.IndexOperations.ensureIndex(Lorg/springframework/data/mongodb/core/index/IndexDefinition;)V
	at org.springframework.session.data.mongo.AbstractMongoSessionConverter.ensureIndexes(AbstractMongoSessionConverter.java:79)
	at org.springframework.session.data.mongo.MongoOperationsSessionRepository.ensureIndexesAreCreated(MongoOperationsSessionRepository.java:123)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor$LifecycleElement.invoke(InitDestroyAnnotationBeanPostProcessor.java:366)
	at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor$LifecycleMetadata.invokeInitMethods(InitDestroyAnnotationBeanPostProcessor.java:311)
	at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor.postProcessBeforeInitialization(InitDestroyAnnotationBeanPostProcessor.java:134)
	... 39 more

@rwinch What are your plans for Spring Session with respect to Spring Data Kay?

@rwinch
Copy link
Member

rwinch commented Nov 28, 2016 via email

@wilkinsona
Copy link
Member Author

Issue for Spring Session compatibility: spring-projects/spring-session#677

wilkinsona added a commit to spring-attic/platform that referenced this issue Nov 30, 2016
@wilkinsona
Start building against Spring Data Kay snapshots
68c8f5e 
See spring-projects/spring-boot#7461
Closes gh-464
@philwebb philwebb modified the milestones: 2.0.0.M1, 2.0.0 Jan 12, 2017
@wilkinsona wilkinsona added the type: blocker An issue that is blocking us from releasing label Jan 20, 2017
@wilkinsona
Copy link
Member Author

wilkinsona commented Jan 20, 2017 •
edited

The Kay M1 bom is missing dependency management for spring-data-ldap. There haven't been any milestones in the Spring Data LDAP 2.0 line yet so we'll need to use snapshots for now. This also means we need Spring Data Kay M2 before Spring Boot 2.0 M1

/cc @olivergierke

@wilkinsona wilkinsona changed the title Upgrade to Spring Data Kay M1 Upgrade to Spring Data Kay M2 Jan 20, 2017
@odrotbohm
Copy link
Member

Technically speaking it's not missing as Spring Data LDAP didn't exist when Kay M1 was released. The snapshots already have the additional dependency declared so that it'll be automatically included in M2.

wilkinsona added a commit that referenced this issue Jan 20, 2017
@wilkinsona
Start building against Spring Data Kay snapshots
d4c4bc3 
See gh-7461
wilkinsona added a commit that referenced this issue Mar 24, 2017
@wilkinsona
Align with API changes in latest Spring Data Kay snapshots
a9a3110 
See gh-7461
@wilkinsona wilkinsona added type: dependency-upgrade A dependency upgrade and removed type: enhancement A general enhancement labels Mar 24, 2017
@wilkinsona wilkinsona changed the title Upgrade to Spring Data Kay M2 Upgrade to Spring Data Kay M3 Apr 21, 2017
wilkinsona added a commit that referenced this issue May 9, 2017
@wilkinsona
Revert "Upgrade to Spring Data Kay M3"
f175f5b 
This reverts commit a8b10f7.

See gh-7461
@wilkinsona wilkinsona reopened this May 9, 2017
snicoll added a commit that referenced this issue May 12, 2017
@snicoll
Upgrade to Lettuce 5.0.0.M2
5f339fc 
See gh-7461
@snicoll
Copy link
Member

snicoll commented May 12, 2017

We missed the upgrade to Lettuce, it's now done (see 5f339fc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: blocker An issue that is blocking us from releasing type: dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
2.0.0.M1
Development

No branches or pull requests
5 participants
@odrotbohm @rwinch @snicoll @philwebb @wilkinsona