RabbitMQ - RetryTemplate configuration hook #11683
Conversation
Provide a mechanism so that users can further configure `RetryTemplate`s used in `RabbitTemplate` and listeners. An example would be to add a retry listener so the user can monitor/log retry attempts. https://stackoverflow.com/questions/48331502/logging-exceptions-thrown-by-message-listeners-for-spring-amqp/48332001#48332001 Or, to set a custom `RetryContextCache`.
spring-projects-issues
added
the
status: waiting-for-triage
| * @since 2.0 | ||
| * | ||
| */ | ||
| public interface RetryTemplateConfigurer<P> { |
There was a problem hiding this comment.
We usually use the term Customizer for this.
| * @since 2.0 | ||
| * | ||
| */ | ||
| public class RabbitTemplateRetryTemplateConfigurer extends RabbitRetryTemplateConfigurer { |
There was a problem hiding this comment.
This empty class seems suspicious.
There was a problem hiding this comment.
It's an empty class because there are two RetryTemplates - one for the consumers and one for the template.
How else can I determine that the user has provided a customizer for one Vs. the other?
| * @param template the template. | ||
| * @param properties the properties. | ||
| */ | ||
| void configure(RetryTemplate template, P properties); |
There was a problem hiding this comment.
There is a mixed of concept here. Usually a customizer is something that applies something extra. It doesn't get the configuration properties object in argument (as it is an auto-configuration concern).
| } | ||
| RetryTemplate template = new RetryTemplate(); | ||
| retryConfigurer.configure(template, retryConfig); | ||
| builder.retryOperations(template); |
There was a problem hiding this comment.
This code doesn't is not equivalent right? RabbitListenerRetryTemplateConfigurer() does more than what you removed as far as I see.
There was a problem hiding this comment.
It's exactly equivalent; just that the old code used a shortcut on the builder.
snicoll
added
the
status: waiting-for-feedback
|
Closed; replaced by #11697 |
snicoll
added
status: duplicate
Provide a mechanism so that users can further configure
RetryTemplatesused in
RabbitTemplateand listeners.An example would be to add a retry listener so the user can monitor/log
retry attempts.
https://stackoverflow.com/questions/48331502/logging-exceptions-thrown-by-message-listeners-for-spring-amqp/48332001#48332001
Or, to set a custom
RetryContextCache.