Add support for anonymousReadOnly in LdapProperties #11744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
reviewed
Jan 23, 2018
| @@ -60,6 +60,11 @@ | |||
| */ | |||
| private Map<String, String> baseEnvironment = new HashMap<>(); | |||
|
|
|||
| /** | |||
| * Enable anonymous read only. | |||
There was a problem hiding this comment.
This description could use some love, something like
Whether read-only operations should use an anonymous environment.
| import org.springframework.boot.test.util.TestPropertyValues; | ||
| import org.springframework.context.annotation.AnnotationConfigApplicationContext; | ||
| import org.springframework.boot.autoconfigure.AutoConfigurations; | ||
| import org.springframework.boot.test.context.runner.ApplicationContextRunner; |
There was a problem hiding this comment.
Can the refactoring of the test be done in a separate commit please? First that with the test unchanged and then an extra commit on top with the feature.
snicoll
added
the
status: waiting-for-feedback
eddumelendez
force-pushed
the
gh-11722
branch
from
8db9b0f
to
f897408
Compare
eddumelendez
force-pushed
the
gh-11722
branch
from
f897408
to
6fb14ed
Compare
snicoll
added
type: enhancement
snicoll
approved these changes
Jan 24, 2018
snicoll
added a commit
that referenced
this pull request
Jan 24, 2018
snicoll
added a commit
that referenced
this pull request
Jan 24, 2018
* pr/11744: Polish "Add support for anonymousReadOnly in LdapProperties" Add support for anonymousReadOnly in LdapProperties Move tests to use ApplicationContextRunner
|
Thanks @eddumelendez - regarding the test refactoring, that's not what I had in mind by "separate commit". What I meant here is first a commit that upgrades the existing tests and then one commit on top that implements the feature (with the relevant tests). I've restructured your PR with that and I've also polished it |
|
@snicoll I'll take it into account next time. Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gh-11722