Persistent Kafka AdminClient for health checks #12200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
|
Also see #11515 (comment) |
Use a single `AdminClient` in `KafkaHealthIndicator` instead of opening a new connection each time. Also fixes spring-projects#12198 If the replication factor can't be determined (older broker), don't perform the replication factor health check.
garyrussell
force-pushed
the
GH-12198
branch
from
f52298a
to
058e52a
Compare
snicoll
pushed a commit
to snicoll/spring-boot
that referenced
this pull request
Feb 26, 2018
If the replication factor can't be determined (older broker), don't perform the replication factor health check. This commit also uses a single `AdminClient` in `KafkaHealthIndicator` instead of opening a new connection each time. See spring-projectsgh-12200
snicoll
added a commit
to snicoll/spring-boot
that referenced
this pull request
Feb 26, 2018
snicoll
pushed a commit
to snicoll/spring-boot
that referenced
this pull request
Feb 26, 2018
This commit uses a single `AdminClient` in `KafkaHealthIndicator` instead of opening a new connection each time. See spring-projectsgh-12200
snicoll
added a commit
to snicoll/spring-boot
that referenced
this pull request
Feb 26, 2018
|
Thanks for the PR. We've been looking at this issue most of today and came to the conclusion it isn't mature enough for us to provide a health indicator out of the box. We'll revert it and reconsider this feature for a latter release. |
snicoll
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a single
AdminClientinKafkaHealthIndicatorinstead of opening a new connectioneach time.
Also fixes #12198
If the replication factor can't be determined (older broker), don't perform the replication
factor health check.