Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thymeleaf sample #13536

Closed
wants to merge 13 commits into from
Closed

Add Thymeleaf sample #13536

wants to merge 13 commits into from

Conversation

0xkookoo
Copy link

Thymeleaf is a modern server-side Java template engine for both web and standalone environments.
I develop a very starting-based guide to implement Thymeleaf in Spring Boot Web as a sample.
This is the first time I contribute to Spring, so if there is any layout or typesetting problems, please let me know. Thanks for all the contributors and maintainers of Spring Boot!

@pivotal-issuemaster
Copy link

@Lisanaaa Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@Lisanaaa Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 21, 2018
@snicoll snicoll changed the title I develop a very starting-based guide to implement Thymeleaf in Spring Boot Web as a sample. Add Thymeleaf sample Jun 21, 2018
@wilkinsona
Copy link
Member

Thanks for opening your first Spring Boot pull request. We already have a number of samples that use Thymeleaf, but their names don't make it clear that they do. Of those samples, spring-boot-sample-web-ui is the one that's most focussed on Thymeleaf. Rather than adding another sample, I think we could just rename that one.

Labeling for team attention to see what the rest of the team think.

@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Jun 21, 2018
@0xkookoo
Copy link
Author

0xkookoo commented Jun 21, 2018

I download the spring-boot-sample-web-ui and run it. But I got some thing wrong,

org.thymeleaf.exceptions.TemplateProcessingException: Could not parse as fragment selection: "fragments :: head(title=~{::title/text()})" (messages/list:3)
	at org.thymeleaf.standard.expression.FragmentSelectionUtils.parseFragmentSelection(FragmentSelectionUtils.java:106)
	at org.thymeleaf.standard.fragment.StandardFragmentProcessor.computeStandardFragmentSpec(StandardFragmentProcessor.java:73)
	at org.thymeleaf.standard.processor.attr.AbstractStandardFragmentHandlingAttrProcessor.computeFragment(AbstractStandardFragmentHandlingAttrProcessor.java:68)

And I think a more clear and easier guide is better for the newbies. No matter what's the next step, I will still contribute. Be in this Spring family.

@philwebb
Copy link
Member

philwebb commented Jun 26, 2018

And I think a more clear and easier guide is better for the newbies

Our samples are somewhat misnamed, we mainly use them to test the integrity of the release. Perhaps we should look at adding a dedicated Thymeleaf sample to spring.io/guides. The repo for that project is https://github.com/spring-guides

@wilkinsona
Copy link
Member

There's an existing Spring MVC and Thymeleaf guide.

@wilkinsona
Copy link
Member

wilkinsona commented Jun 28, 2018

We discussed this yesterday, and decided that what's being proposed here is already covered by the existing guide. I've opened spring-guides/gs-serving-web-content#24 to hopefully make it a bit clearer that the guide uses Thymeleaf. We've decided not to rename our existing web UI sample as it doesn't focus specifically on Thymeleaf but also uses Bootstrap etc. Thanks anyway.

@wilkinsona wilkinsona closed this Jun 28, 2018
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants