Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose InfoContributor information via the metrics endpoint #13946

Closed
wants to merge 3 commits into from

Conversation

tbilou
Copy link

@tbilou tbilou commented Jul 30, 2018

Hi,

this PR exposes InfoContributor information via the metrics endpoint (see #12348)

Need some feedback regarding the flattenKeys recursive implementation. This is a problem that has been solved many times, but I was unable to find an existing method I could re-purpose for this case. Maybe someone can point out an existing implementation in spring boot

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 30, 2018
@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Jul 31, 2018
@snicoll snicoll changed the title Expose InfoContributor information via the metrics endpoint (Fixes Gh-12348) Expose InfoContributor information via the metrics endpoint Jul 31, 2018
@snicoll
Copy link
Member

snicoll commented Aug 4, 2018

@tbilou thanks for the PR but exposing the whole content of the info endpoint as metrics is not something we want to do. Looking back at the original request, the focus was on git and build information and while the reporter mentioned "all information", they really only used git and build.

I think we need to revisit this use case and figure out what we want to do. Perhaps an easy way to expose a MeterFilter with such information would be interesting. But InfoContributor shouldn't be the source. BuildProperties and GitProperties might. Thanks anyway

@snicoll snicoll closed this Aug 4, 2018
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants