Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of deprecated Mongo API #14318

Closed

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented Sep 6, 2018

We now use com.mongodb.MongoClientSettings to configure the reactive MongoDB driver. This is a breaking change as MongoClientSettingsBuilderCustomizer and user-provided MongoClientSettings beans referenced the package the settings type from com.mongodb.async.client.

MongoClient.getSettings() is deprecated and still in use within tests until a replacement is available.


Related to this change and #14176, we should provide a com.mongodb.MongoClientSettings factory as soon as we consider migrating to com.mongodb.client.MongoClient as the default client implementation (currently: com.mongodb.MongoClient) to provide the same configuration to the reactive and synchronous drivers. com.mongodb.MongoClient provides still access to the legacy DBObject API whereas com.mongodb.client.MongoClient does not expose the DBObject API.

….async.client.MongoClientSettings.

We now use com.mongodb.MongoClientSettings to configure the reactive MongoDB driver. This is a breaking change as MongoClientSettingsBuilderCustomizer and user-provided MongoClientSettings beans referenced the package the settings type from com.mongodb.async.client.

MongoClient.getSettings() is deprecated and still in use within tests until a replacement is available.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 6, 2018
@snicoll snicoll self-assigned this Sep 6, 2018
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 6, 2018
@snicoll snicoll added this to the 2.1.0.M3 milestone Sep 6, 2018
@snicoll snicoll changed the title Use com.mongodb.MongoClientSettings instead of deprecated com.mongodb.async.client.MongoClientSettings Fix use of deprecated Mongo API Sep 6, 2018
snicoll pushed a commit that referenced this pull request Sep 6, 2018
We now use com.mongodb.MongoClientSettings to configure the reactive
MongoDB driver. This is a breaking change as
MongoClientSettingsBuilderCustomizer and user-provided
MongoClientSettings beans referenced the package the settings type
from com.mongodb.async.client.

MongoClient.getSettings() is deprecated and still in use within tests
until a replacement is available.

See gh-14318
@snicoll snicoll closed this in 4d03199 Sep 6, 2018
snicoll added a commit that referenced this pull request Sep 6, 2018
* pr/14318:
  Polish "Fix use of deprecated Mongo API"
  Fix use of deprecated Mongo API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants